Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.19] 🐛 Use leader elector with client timeout #3031

Merged
merged 3 commits into from
Dec 2, 2024
Merged

[release-0.19] 🐛 Use leader elector with client timeout #3031

merged 3 commits into from
Dec 2, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #3028

/assign vincepri

@alvaroaleman
warning: Use leader elector with client timeout
0170742 
This change makes the leader elector use a client that internally has
a smaller timeout than the renew deadline, which avoids a situation
where a single request timing out makes us lose the leader lease.
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 30, 2024
Merged
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 30, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 30, 2024
vincepri
vincepri approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 87bfefbacac102f2c5234f4c79c1d3ddc9020dc5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2024
@alvaroaleman
Copy link
Member

/hold

This is a breaking change

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2024
vincepri and others added 2 commits December 2, 2024 07:35
@vincepri
🐛 Fix RenewDeadline typo in leader election
4bc3811 
Signed-off-by: Vince Prignano <vince@prigna.com>
@alvaroaleman @vincepri
🌱 Make using leader elector with client timeout non-breaking
2a0ce59 
This change is a follow-up to the one that introduces the usage of the
leader-elector with client timeout. That change was breaking because it
introduces a new option and always assumed it was set. This change makes
us only use that option if its actually set.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2024
@vincepri vincepri changed the title [release-0.19] ⚠️ Use leader elector with client timeout [release-0.19] 🐛 Use leader elector with client timeout Dec 2, 2024
@vincepri
Copy link
Member

vincepri commented Dec 2, 2024

/hold cancel
/cherry-pick release-0.18

@k8s-infra-cherrypick-robot
Copy link
Author

@vincepri: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you.

In response to this:

/hold cancel
/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2024
@vincepri
Copy link
Member

vincepri commented Dec 2, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: da40cb6923abd6536f2d3d4be7320b0573ae2748

@k8s-ci-robot k8s-ci-robot merged commit 0823530 into kubernetes-sigs:release-0.19 Dec 2, 2024
9 checks passed
@k8s-infra-cherrypick-robot
Copy link
Author

@vincepri: new pull request created: #3036

In response to this:

/hold cancel
/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FillZpp FillZpp Awaiting requested review from FillZpp

@inteon inteon Awaiting requested review from inteon

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k8s-infra-cherrypick-robot @k8s-ci-robot @alvaroaleman @vincepri