Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Enable labels list options in fake client #410

Merged
merged 2 commits into from
May 10, 2019
Merged

🐛 Enable labels list options in fake client #410

merged 2 commits into from
May 10, 2019

Commits on Apr 26, 2019

  1. Enable labels list options in fake client 

    This commit allows passing label matches to the fake client List()
function.

This is done in a way similar to the CachedReader. Both now share a
common call to `objectutil.FilterWithLabels`.

Signed-off-by: sebgl <contact.sebgl@gmail.com>
    @sebgl @ingvagabund
    sebgl authored and ingvagabund committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    04b1b70 View commit details
    Browse the repository at this point in the history

  2. Move some code under filterListItems to decrease cyclomatic complexity 

    To eliminate:
pkg/cache/internal/cache_reader.go:91::warning: cyclomatic complexity 12 of function (*CacheReader).List() is high (> 10) (gocyclo)
pkg/client/fake/client.go:92::warning: cyclomatic complexity 12 of function (*fakeClient).List() is high (> 10) (gocyclo)
    @ingvagabund
    ingvagabund committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    e1ec14f View commit details
    Browse the repository at this point in the history