🐛 Enable labels list options in fake client #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows passing label matches to the fake client List() function. This is done in a way similar to the CachedReader. Both now share a common call to `objectutil.FilterWithLabels`. Signed-off-by: sebgl <contact.sebgl@gmail.com>
k8s-ci-robot
added
cncf-cla: yes
|
@sebgl @DirectXMan12 PTAL |
2 tasks
ingvagabund
changed the title
To eliminate: pkg/cache/internal/cache_reader.go:91::warning: cyclomatic complexity 12 of function (*CacheReader).List() is high (> 10) (gocyclo) pkg/client/fake/client.go:92::warning: cyclomatic complexity 12 of function (*fakeClient).List() is high (> 10) (gocyclo)
cynepco3hahue
pushed a commit
to cynepco3hahue/machine-api-operator
that referenced
this pull request
Apr 29, 2019
Make possible to call to object List with label selector. We should revert it back to https://github.com/kubernetes-sigs/controller-runtime/tree/release-0.1 once kubernetes-sigs/controller-runtime#410 merged
cynepco3hahue
pushed a commit
to cynepco3hahue/machine-api-operator
that referenced
this pull request
May 7, 2019
Make possible to call to object List with label selector. We should revert it back to https://github.com/kubernetes-sigs/controller-runtime/tree/release-0.1 once kubernetes-sigs/controller-runtime#410 merged
DirectXMan12
changed the title
|
added the appropriate prefix to the title /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
drop support for legacy (v0) projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows passing label matches to the fake client List()
function.
This is done in a way similar to the CachedReader. Both now share a
common call to
objectutil.FilterWithLabels.Signed-off-by: sebgl contact.sebgl@gmail.com
Backporting #311 into release-0.1 branch.