List deployments on label selectors with fake client not working for AppsV1().Deployments

[nilekhc]

With Fake client, when try to list deployments on label selector with AppsV1().Deployments() is not working.
Similar call with ExtensionsV1beta1().Deployments() works perfectly fine.
Eg.
Working :-
fake.NewSimpleClientset().ExtensionsV1beta1().Deployments().List(metav1.ListOptions{
LabelSelector: "<some=label>",
})

Not working :-
fake.NewSimpleClientset().AppsV1().Deployments().List(metav1.ListOptions{
LabelSelector: "<some=label>",
})

[liggitt]

can you provide the code for the mock deployment you are having trouble listing?

[nilekhc]

It's the same in description. Working one returns valid deployment list items. Not working one returns nil.

[liggitt]

can you provide the content of the deployments in question (specifically, whether they include labels in their objectmeta.labels field)

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[robbie-demuth]

I ran into this issue today, but with StatefulSets. I think the issue is that the fake client doesn't support using labels when performing list requests. Instead, it returns all objects of the given type within the specified namespace. This is documented on the internal ObjectTracker type and appears to be tracked by kubernetes-sigs/controller-runtime#410

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.