support non leader election components #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
mengqiy
force-pushed
the
nonleaderelection
branch
from
63b1b3e
to
bdb3e3f
Compare
k8s-ci-robot
added
size/M
mengqiy
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
| @@ -41,12 +41,9 @@ type ChaosPodStatus struct { | |||
| LastRun metav1.Time `json:"lastRun,omitempty"` | |||
| } | |||
|
|
|||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | |||
There was a problem hiding this comment.
you need an object-gen marker here, no?
pkg/manager/internal.go
Outdated
| @@ -237,6 +246,8 @@ func (cm *controllerManager) Start(stop <-chan struct{}) error { | |||
| go cm.serveMetrics(cm.internalStop) | |||
| } | |||
|
|
|||
| go cm.startHA() | |||
There was a problem hiding this comment.
it's not clear what HA means -- we should say "LeaderElection" or something instead (e.g. NeedsLeaderElection, startWithLeaderElection, etc).
mengqiy
force-pushed
the
nonleaderelection
branch
from
bdb3e3f
to
257089c
Compare
k8s-ci-robot
added
size/L
webhook server can be run in the non-leaderelection mode
mengqiy
force-pushed
the
nonleaderelection
branch
from
257089c
to
ea5a354
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
mengqiy
changed the title
This was referenced May 21, 2019
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
cleanup: deleted old docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controller manager support 2 set of runables
fixes: #356