Implement LeaderElectionRunnable interface for CertRotator #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirrageS
force-pushed
the
januszm-leader-election
branch
2 times, most recently
from
0d73a8d
to
ed8e2a5
Compare
Signed-off-by: Janusz Marcinkiewicz <januszm@nvidia.com>
VirrageS
force-pushed
the
januszm-leader-election
branch
from
ed8e2a5
to
f6da332
Compare
maxsmythe
approved these changes
Sep 28, 2022
sozercan
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR implements
LeaderElectionRunnableforCertRotator. This is needed for case when theCertRotatoris used in manager that implements leader election. In such case we might want to runCertRotatorin all replicas (now this will be default) instead of running only on the leader (currently the default). The reason why we need to runCertRotatoron all replicas is to unblock the registering the webhooks (which wait for theCertRotatorto finish setup) on all replicas (webhooks by default run on all replicas even in leader election mode).This change has no impact on workflows that don't use leader election like gatekeeper.
See kubernetes-sigs/controller-runtime#424 and kubernetes-sigs/controller-runtime#441 for more context.