✨ enable conversion webhook in webhook builder #502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Controller builder now only build controller; while webhook builder only build webhook.
Main changes: - Integrate conversion webhook in webhook builder - Register conversion handler only when a type is convertible
droot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
- Removed examples/conversion dir instead use testdata project under pkg/webhook/conversion - Enhanced tests to add spoke to spoke conversion
k8s-ci-robot
added
size/XXL
|
@droot Please rebase and I will take another pass. |
|
closing this in favor of #502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables auto registration of conversion webhook on webhook server. New behavior is -- if a type implements convertible, then conversion webhook is auto registered in webhook builder. This makes it consistent with other webhooks.
Note: this is rebased on #497 . Sending in for early feedback.