Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ enable conversion webhook in webhook builder #502

Closed
wants to merge 3 commits into from
Closed

✨ enable conversion webhook in webhook builder #502

wants to merge 3 commits into from

Commits on Jun 24, 2019

  1. ⚠️ split the webhook builder out as a separate builder. 

    Controller builder now only build controller; while webhook builder only build webhook.
    Mengqi Yu committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    6cfea26 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. ✨ wire conversion webhook in webhook builder 

    Main changes:
 - Integrate conversion webhook in webhook builder
 - Register conversion handler only when a type is convertible
    @droot
    droot committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    6026860 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2019

  1. 🏃 enhanced conversion webhook tests 

     - Removed examples/conversion dir instead use testdata project under
 pkg/webhook/conversion
 - Enhanced tests to add spoke to spoke conversion
    @droot
    droot committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    203d5b9 View commit details
    Browse the repository at this point in the history