Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 (:book:, docs) Remove references to 'download-binaries.sh' #762

Merged
merged 1 commit into from
Jan 22, 2020
+2 −9
Merged

📖 (:book:, docs) Remove references to 'download-binaries.sh' #762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/internal/testing/integration/assets/bin/.gitkeep
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
This directory will be the home of some binaries which are downloaded with `pkg/framework/test/scripts/download-binaries`.
Copy link
Contributor

@hoegaarden hoegaarden Jan 20, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might want to keep that directory, for now, as the assets are currently still being downloaded to .../pkg/internal/testing/integration/assets/bin/, see:

controller-runtime/hack/check-everything.sh

Line 86 in 8c39906

fetch_kb_tools "${hack_dir}/../pkg/internal/testing/integration/assets"
.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, you're right, thanks. Updated...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: If you want to remove references to 'download-binaries.sh' you might want to change the content of .gitkeep to something like:

Suggested change
This directory will be the home of some binaries which are downloaded with `pkg/framework/test/scripts/download-binaries`.
This directory will be the home of some binaries which are downloaded with `make test` or `.../hack/check-everything.sh`.

🤷‍♂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, right 🙈 thanks

This directory will be the home of some binaries which are downloaded with `make test` or `.../hack/check-everything.sh`.
9 changes: 1 addition & 8 deletions pkg/internal/testing/integration/doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ needed to provide this API is managed by this framework.
Quickstart
If you want to test a kubernetes client against the latest kubernetes APIServer
and Etcd, you can use `./scripts/download-binaries.sh` to download APIServer
and Etcd binaries for your platform. Then add something like the following to
Add something like the following to
your tests:
cp := &integration.ControlPlane{}
Expand Down Expand Up @@ -71,11 +69,6 @@ APIServer, Etcd or KubeCtl.
framework tries to use the binaries `kube-apiserver`, `etcd` or `kubectl` in
the directory `${FRAMEWORK_DIR}/assets/bin/`.
For convenience this framework ships with
`${FRAMEWORK_DIR}/scripts/download-binaries.sh` which can be used to download
pre-compiled versions of the needed binaries and place them in the default
location (`${FRAMEWORK_DIR}/assets/bin/`).
Arguments for Etcd and APIServer
Those components will start without any configuration. However, if you want or
Expand Down