-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃摉 (:book:, docs) Remove references to 'download-binaries.sh' #762
馃摉 (:book:, docs) Remove references to 'download-binaries.sh' #762
Conversation
Hi @alenkacz. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -1 +0,0 @@ | |||
This directory will be the home of some binaries which are downloaded with `pkg/framework/test/scripts/download-binaries`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might want to keep that directory, for now, as the assets are currently still being downloaded to .../pkg/internal/testing/integration/assets/bin/
, see:
fetch_kb_tools "${hack_dir}/../pkg/internal/testing/integration/assets" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, you're right, thanks. Updated...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: If you want to remove references to 'download-binaries.sh' you might want to change the content of .gitkeep
to something like:
This directory will be the home of some binaries which are downloaded with `pkg/framework/test/scripts/download-binaries`. | |
This directory will be the home of some binaries which are downloaded with `make test` or `.../hack/check-everything.sh`. |
馃し鈥嶁檪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, right 馃檲 thanks
b9e99b4
to
d4b6209
Compare
d4b6209
to
98e5915
Compare
/lgtm |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alenkacz, DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When bringing in the testing framework in #749 download-binaries.sh was not moved over but the references to it remain in the docs. This PR removes them.