⚠ Bring in testing framework #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is bringing in https://github.com/kubernetes-sigs/testing_frameworks/tree/694245ac7b60bff90cc8b159fbd8ddb7efe3f218. The package is fully integrated into the local tooling, e.g.: - updated import path - uses the same binary assets for testing - runs its tests as part of `make test` and on prow - updated OWNERS In the original repo the CLA bot was enabled, thus all commits that have been squashed here should be fine regarding the CLA. All authors and committers of the squashed commits have been added here as co-authors. Co-authored-by: Aaron Crickenberger <spiffxp@gmail.com> Co-authored-by: Gareth Smith <gsmith@pivotal.io> Co-authored-by: Hannes Hörl <hhorl@pivotal.io> Co-authored-by: Josh Hill <jhill@pivotal.io> Co-authored-by: Lantao Liu <lantaol@google.com> Co-authored-by: Maru Newby <marun@redhat.com> Co-authored-by: Mengqi Yu <mengqiy@google.com> Co-authored-by: Steven Chung <steve.chung7@gmail.com>
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm I think we'll want to play around with this structure a bit eventually, but this is fine for now cc @mengqiy |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, hoegaarden The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
xref: #676 |
This was referenced Jan 18, 2020
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
🏃 remove Dep manifests from KB repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is bringing in https://github.com/kubernetes-sigs/testing_frameworks/tree/694245ac7b60bff90cc8b159fbd8ddb7efe3f218.
The package is fully integrated into the local tooling, e.g.:
make testand on prowIn the original repo the CLA bot was enabled, thus all commits that have been
squashed here should be fine regarding the CLA.
All authors and committers of the squashed commits have been added here as
co-authors.
Superseds #714 (see: #714 (comment))
/assign @DirectXMan12 @gerred