Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (:sparkles, minor) APIServer defaults deduplication #763

Merged
merged 1 commit into from
Feb 4, 2020
Merged

✨ (:sparkles, minor) APIServer defaults deduplication #763

merged 1 commit into from
Feb 4, 2020

Conversation

alenkacz
Copy link
Contributor

After #749 the defaults to API server are now defined in two places - deep into the imported test framework and in envtest. I think it's enough to keep the defaults at one place - that is what this PR does.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @alenkacz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2020
DirectXMan12
DirectXMan12 reviewed Jan 22, 2020
View reviewed changes
pkg/envtest/server.go
func (te Environment) getAPIServerFlags() []string {
// Set default API server flags if not set.
if len(te.KubeAPIServerFlags) == 0 {
return DefaultKubeAPIServerFlags
return []string{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we alias the above global variable too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the DefaultKubeAPIServerFlags unused after this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to remove it 🤦‍♀ thanks

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2020
@alenkacz
Copy link
Contributor Author

/retest

vincepri
vincepri approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/assign @gerred @DirectXMan12

for approval

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 23, 2020
@alenkacz
Copy link
Contributor Author

alenkacz commented Feb 1, 2020

@DirectXMan12 @gerred can you please take a look?

@gerred
Copy link
Contributor

gerred commented Feb 4, 2020

/approve

looks good!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alenkacz, gerred

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@gerred
Copy link
Contributor

gerred commented Feb 4, 2020

hmm thought these tests were passing when I approved? @alenkacz cc

@alenkacz
Copy link
Contributor Author

alenkacz commented Feb 4, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5e2c4c8 into kubernetes-sigs:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 DirectXMan12 left review comments

@vincepri vincepri vincepri approved these changes

@pwittrock pwittrock Awaiting requested review from pwittrock

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@DirectXMan12 DirectXMan12

@gerred gerred

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alenkacz @k8s-ci-robot @gerred @DirectXMan12 @vincepri