-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Added Encoder Config Options field. #915
✨ Added Encoder Config Options field. #915
Conversation
Hi @bharathi-tenneti. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after returning an error for invalid flag values.
/retest |
bc38731
to
a4ef374
Compare
This PR is being re-worked to add Encoder Config Options , rather than specific time encoder flag, seen in the earlier implementations. |
d47a2cb
to
40df381
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bharathi-tenneti, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
40df381
to
eccba7c
Compare
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
1 similar comment
/retest |
/test pull-controller-runtime-test-master |
This looks pretty good to me now based on our convo in the community meeting last time. @DirectXMan12 Does this align with what you were thinking now? |
/assign @DirectXMan12 |
c480736
to
c6b1f07
Compare
/lgtm |
/hold cancel |
Description: This PR adds field in Options struct, for adding Encoder configuration options programmatically.
Motivation: This will make it easier for operator developers to specify different Encoder options.
Fixes: #912