Bind log configuration flags by default in main.go

[bharathi-tenneti]

Description:
Update the main.go scaffold code to configure log options from command line flags via zap.BindFlags()
Example:

opts := zap.Options{}
opts.BindFlags(flag.CommandLine)
flag.Parse()
logger := zap.New(zap.UseFlagOptions(&opts))
log.SetLogger(logger)

This way, the log options can be configured at runtime via flags in the manager’s deployment manifest e.g:

  spec:
    containers:
    - command:
      - /manager
      args:
      - --enable-leader-election
      - --zap-devel=true
      - --zap-log-level=debug

/kind feature

[bharathi-tenneti]

/cc @hasbro17 @mengqiy

[bharathi-tenneti]

Can we have some inputs on this issue?

[camilamacedo86]

It would be to apply the changes made in kubernetes-sigs/controller-runtime#915 and kubernetes-sigs/controller-runtime#1035

[camilamacedo86]

It shows a follow up of : #1721

@georgettica would you like to help on this one? WDYT?

[georgettica]

I can and I will,
so the issue as I see it @bharathi-tenneti is that you want a slightly more configurable template..

as of v3 and my PR, you can get these configurations but the only difference is that the debug level is forced through the code and not the config.

do you think moving all of the configs outside of the main.go is the better way to go? I have no clear agenda related to that.

if you want help changing the code inside the template I can gladly assist / create the PR to make it a reality

[estroz]

Those flags aren't actually needed since Development: true is set by default. If anyone thinks scaffolding flags in manager.yaml is better and has a reasonable argument for doing so over the current default setup, please comment and we can re-consider this issue.

/close

[k8s-ci-robot]

@estroz: Closing this issue.

In response to this:

Those flags aren't actually needed since Development: true is set by default. If anyone thinks scaffolding flags in manager.yaml is better and has a reasonable argument for doing so over the current default setup, please comment and we can re-consider this issue.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[camilamacedo86]

+1 to close this one. However, if more community members think that would be better we scaffold the flags instead than, please feel free to raise an issue with this as RFE for we are able to address.

[nathanperkins]

Is there a way to set log levels via command-line flag with the scaffolded code?

It looks like we're having to change the code to support this.

[estroz]

You're looking for --zap-log-level.