-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Skip to generate properties for structs defined in k8s.io/api #460
🐛 Skip to generate properties for structs defined in k8s.io/api #460
Conversation
Welcome @FillZpp! |
d9673a4
to
4c7be73
Compare
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Signed-off-by: Siyu Wang <FillZpp.pub@gmail.com>
4c7be73
to
a45502c
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Siyu Wang FillZpp.pub@gmail.com
Ⅰ. Describe what this PR does
Skip to generate properties for structs defined in
k8s.io/api
to fixes those incorrect fields/validation and also avoid huge CRD yaml.Actually,
k8s.io/api
is ignored in release-0.1. We should do this again in release-0.2 and 0.3.Ⅱ. Does this pull request fix one issue?
Fixes: #457 #444