-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] CloneSet requires dataSource #301
Comments
We install the CRD from here, which has the dataSource requirement I believe: https://github.com/openkruise/kruise/blob/master/config/crds/apps.kruise.io_clonesets.yaml Versus the one from here that does not have the CRD: https://github.com/openkruise/kruise/blob/master/charts/kruise/v0.5.0/templates/apps_v1alpha1_cloneset.yaml |
This seems to be a controller-tools problem. We have filed this issue to track kubernetes-sigs/controller-tools#457 By the mean time, we may add a temporal script to manually workaround this problem. @FillZpp. |
I have submitted a PR kubernetes-sigs/controller-tools#460 for controller-tools. If it can not be released in the short term, I will use a kruise-fork controller-tools to fix it for a while. |
@FillZpp It happened when I applied cloneset with pvcs. And when I apply the new crd yaml. The problem still exists. Since I delete and recreate the crd, it repaired. But this will cause the cloneset object deleted. |
@shiyan2016 You may replace the crd yaml using |
What happened:
Applied a CloneSet without a dataSource and got this error:
What you expected to happen:
The config is applied.
How to reproduce it (as minimally and precisely as possible):
Apply a CloneSet config that does not include
spec.volumeClaimTemplates.spec.dataSource
.Anything else we need to know?:
Link to slack discussion:
https://kruise-workspace.slack.com/archives/CK5G41AF3/p1593025696007200
Environment:
kubectl version
): 1.18cat /etc/os-release
):uname -a
):The text was updated successfully, but these errors were encountered: