Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CRDs using openkruise/controller-tools #310

Merged

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Jul 8, 2020

Signed-off-by: Siyu Wang FillZpp.pub@gmail.com

Ⅰ. Describe what this PR does

Fix CRDs using openkruise/controller-tools.

Note that we can remove this if controller-tools has merged and released kubernetes-sigs/controller-tools#457.

Ⅱ. Does this pull request fix one issue?

Fixes #301

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Siyu Wang <FillZpp.pub@gmail.com>
Copy link
Member

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fei-Guo Fei-Guo merged commit 08dc51e into openkruise:master Jul 8, 2020
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CloneSet requires dataSource
2 participants