Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Remove unneeded caBundle: Cg== value #495

Merged
merged 1 commit into from
Oct 13, 2020
Merged

🐛 Remove unneeded caBundle: Cg== value #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/crd/markers/zz_generated.markerhelp.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions pkg/webhook/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,6 @@ func (c Config) clientConfig() admissionregv1.WebhookClientConfig {
Namespace: "system",
Path: &path,
},
// OpenAPI marks the field as required before 1.13 because of a bug that got fixed in
// https://github.com/kubernetes/api/commit/e7d9121e9ffd63cea0288b36a82bcc87b073bd1b
// Put "\n" as an placeholder as a workaround til 1.13+ is almost everywhere.
CABundle: []byte("\n"),
}
}

Expand Down
2 changes: 0 additions & 2 deletions pkg/webhook/testdata/manifests.v1beta1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ webhooks:
- v1
- v1beta1
clientConfig:
caBundle: Cg==
service:
name: webhook-service
namespace: system
Expand Down Expand Up @@ -38,7 +37,6 @@ metadata:
name: validating-webhook-configuration
webhooks:
- clientConfig:
caBundle: Cg==
service:
name: webhook-service
namespace: system
Expand Down
2 changes: 0 additions & 2 deletions pkg/webhook/testdata/manifests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ webhooks:
- v1
- v1beta1
clientConfig:
caBundle: Cg==
service:
name: webhook-service
namespace: system
Expand Down Expand Up @@ -41,7 +40,6 @@ webhooks:
- v1
- v1beta1
clientConfig:
caBundle: Cg==
service:
name: webhook-service
namespace: system
Expand Down