馃悰 Remove unneeded caBundle: Cg== value #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matthchr
commented
Oct 1, 2020
matthchr
commented
- As per the comment in source, this field is no longer needed.
- As per the comment in source, this field is no
longer needed.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
Related to kubernetes-sigs/kubebuilder#1699 |
|
@DirectXMan12 Can you take a look at this? |
matthchr
commented
Oct 5, 2020
| @@ -198,7 +198,7 @@ func (Minimum) Help() *markers.DefinitionHelp { | |||
| return &markers.DefinitionHelp{ | |||
| Category: "CRD validation", | |||
| DetailedHelp: markers.DetailedHelp{ | |||
| Summary: "specifies the minimum numeric value that this field can have.", | |||
| Summary: "specifies the minimum numeric value that this field can have. Negative integers are supported.", | |||
There was a problem hiding this comment.
Note: I didn't add this... maybe somebody forgot to regenerate something?
There was a problem hiding this comment.
yeah, someone forgot to regenerate, and the testing missed it somehow.
|
@DirectXMan12 @pwittrock - Can you take a look? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, matthchr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
julianKatz
added a commit
to julianKatz/gatekeeper
that referenced
this pull request
May 6, 2021
In support of the move to v1 CRDs, we will need up-to-date generation tooling. Gatekeeper was still on controller-gen 0.3.0, so this PR updates that to 0.5.0. One notable detail here is the removal of the caBundle field from the webhook configurations. This is not a mistake. This field was related to a bug in k8s that is now fixed, and thus the field was removed from the generated output in controller-gen 0.4.1. See kubernetes-sigs/controller-tools#495 for more info. This PR contributes to open-policy-agent#550 Signed-off-by: juliankatz <juliankatz@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.