🐛 Remove unneeded caBundle value from webhook patches (V3 only)

[matthchr]

Instead of having a dummy value in caBundle, (caBundle: Cg==), instead just omit that field entirely as it is not required.
Doing this means that repeated kubectl apply operators on a CRD work better, in accordance with the documented behavior of apply and how it considers last-applied-configuration, since they do not change the resourceVersion of the CRD.

This fixes #1684.

[k8s-ci-robot]

Welcome @matthchr!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @matthchr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[matthchr]

@DirectXMan12 can you weigh in when you get a chance on the question I asked above about the files that still have Cg== in them?

[DirectXMan12]

hmm... @camilamacedo86 would know that better, but make generate should be generating everything. If you delete those files do they get recreated?

[matthchr]

Yeah, if I delete those files they are in fact regenerated (and they have Cg== in them). I'm not sure where it's coming from though as the only place that has Cg== is those files.

~/go/src/sigs.k8s.io/kubebuilde $ grep -rEli "Cg==" *

testdata/project-v2/config/webhook/manifests.yaml
testdata/project-v2-multigroup/config/webhook/manifests.yaml
testdata/project-v3/config/webhook/manifests.yaml
testdata/project-v3-multigroup/config/webhook/manifests.yaml

I must be missing someplace - will look through how make generate is making those files.

[matthchr]

I think it's being created by controller-tools here?

Looks like maybe I need to send a PR there as well? Not entirely sure how to coordinate between the two repos - maybe controller_tools needs to merge first?

[DirectXMan12]

yeah, just file a PR on controller-tools. You can either merge that first, or merge this then file another PR here to update the CT version in v3 & update the golden files.

[matthchr]

I've sent a PR for controller-tools too.

[camilamacedo86]

Hi @matthchr,

The make generate will remove the testdata/ directory and re-generate all projects. We ought to run that when we change anything in the templates. since we also ought to perform changes in pkg/plugin/v3/ the project-v2-* samples should not change as well.

[camilamacedo86]

/ok-to-test
/approve

It shows ok for me 👍
really tks for your contribution. we need more +1 OK to get it merged.

[camilamacedo86]

/test pull-kubebuilder-e2e-k8s-1-15-3

[matthchr]

@camilamacedo86 - it looks like a test timed out in the v2 tests... I don't think I changed anything there though (it was all reverted).

Is this just a flaky test?

[camilamacedo86]

/test pull-kubebuilder-e2e-k8s-1-14-1

[matthchr]

@camilamacedo86 @DirectXMan12 - pinging on this, would be good to get it merged now that the controller-tools PR has merged.

[camilamacedo86]

.

[camilamacedo86]

/approve

It shows ok for me. 👍

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, matthchr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

I understand that we can

/lgtm

this one.
It was done in the controller-tools already too. Also, it is done only for v3+ and was checked and drove by @DirectXMan12 as well.

[camilamacedo86]

/lgtm