Upgrade controller-gen to 0.5.0 #1285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In support of the move to v1 CRDs, we will need up-to-date generation tooling. Gatekeeper was still on controller-gen 0.3.0, so this PR updates that to 0.5.0. One notable detail here is the removal of the caBundle field from the webhook configurations. This is not a mistake. This field was related to a bug in k8s that is now fixed, and thus the field was removed from the generated output in controller-gen 0.4.1. See kubernetes-sigs/controller-tools#495 for more info. This PR contributes to open-policy-agent#550 Signed-off-by: juliankatz <juliankatz@google.com>
|
@julianKatz i think we already have this as part of #1250 |
|
Ah, this was unnecessary. Nevermind! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of the move to v1 CRDs, we will need up-to-date generation
tooling. Gatekeeper was still on controller-gen 0.3.0, so this PR
updates that to 0.5.0.
One notable detail here is the removal of the caBundle field from the
webhook configurations. This is not a mistake. This field was related
to a bug in k8s that is now fixed, and thus the field was removed from
the generated output in controller-gen 0.4.1.
See kubernetes-sigs/controller-tools#495 for more info.
This PR contributes to #550
Signed-off-by: juliankatz juliankatz@google.com