Fix domain resource issues in controller #54
Conversation
k8s-ci-robot
added
size/M
| } | ||
| a.ResourcePackage = path.Join(a.Repo, "pkg", "apis") | ||
| a.GroupDomain = a.Resource.Group + "." + a.Domain | ||
| } |
There was a problem hiding this comment.
we can capture this logic in a separate function so that it can be called by both Test/Controller methods ?
| } | ||
| a.ResourcePackage = path.Join(a.Repo, "pkg", "apis") | ||
| } | ||
|
|
||
| var controllerTestTemplate = `{{ .Boilerplate }} | ||
|
|
||
| package {{ lower .Resource.Kind }} |
There was a problem hiding this comment.
We should add two tests by modifying the generate_golden.sh by creating controller for existing type under pkg/apis which matches the group with core and second one with controller-only for core resource.
k8s-ci-robot
added
size/XL
- bind resource for controller based on whether resource is created. 1) If resource is created in project, bind with created resource. 2) If resource not created, gkv matches core types, bind with core-types. 3) Else, using specified resourcePath by flag --resource-pkg-path (TODO) - change test domain from k8s.io to testproject.org
droot
added
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: fanzhangio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bind resource for controller based on whether resource is created.
Fix issues:
kubernetes-sigs/kubebuilder#342
kubernetes-sigs/kubebuilder#335
kubernetes-sigs/kubebuilder#338