Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix domain resource issues in controller #343

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

fanzhangio
Copy link

  • bind resource for controller based on whether resource is created.
    1. If resource is created in project, bind with created resource.
    2. If resource not created, gkv matches core types, bind with core-types.
    3. Else, using specified resourcePath by flag --resource-pkg-path (TODO)

#342
#335
#338

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 2, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 2, 2018
Copy link
Contributor

@interma interma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 thanks for your fix.

@DirectXMan12
Copy link
Contributor

This presumably needs to be fixed controller-tools directly, not in the vendor directory.

@droot
Copy link
Contributor

droot commented Aug 2, 2018

@fanzhangio the changes are on right track, but needs to be done in https://github.com/kubernetes-sigs/controller-tools first and then vendor'd in here.

@fanzhangio
Copy link
Author

PR kubernetes-sigs/controller-tools#54

This PR will be updated by dumping vendors if above PR merged.

- fix in controller-tools and vendor in kubebuilder
- bind resource for controller based on whether resource is created.
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2018
@fanzhangio
Copy link
Author

Done

@droot droot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: fanzhangio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants