-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixed panic when parsing selector expressions containing composite literals #648
🐛 Fixed panic when parsing selector expressions containing composite literals #648
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Welcome @kralicky! |
Hi @kralicky. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
return nil | ||
default: | ||
return c | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT about adding a test to ensure the scenario raised?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing, I will add a test.
@camilamacedo86 I added a field that would cause a panic (without this patch) to the test cronjob spec - let me know if this works, or if there is a better place to add a test. |
Hey, we've hit this bug while developing an operator as well, any progress here? |
/ok-to-test |
/lgtm |
4c0de4c
to
44375eb
Compare
…terals Signed-off-by: Joe Kralicky <joe.kralicky@suse.com>
Signed-off-by: Joe Kralicky <joe.kralicky@suse.com>
44375eb
to
3102f89
Compare
@joelanford I had to rebase which cleared the lgtm label. Could you take another look at this? Thanks! |
/lgtm I tested it and reviewed the code - looks like it solves it neatly. Great work! @pwittrock @joelanford can you please approve? |
/approve Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlmogBaku, joelanford, kralicky The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the fix! I'm looking forward to this being released. |
This fixes #613
Signed-off-by: Joe Kralicky joe.kralicky@suse.com