-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support gcp secret manager for root user credentials #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #190 +/- ##
==========================================
- Coverage 65.51% 63.86% -1.66%
==========================================
Files 6 6
Lines 522 559 +37
==========================================
+ Hits 342 357 +15
- Misses 139 156 +17
- Partials 41 46 +5
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nakamasato
changed the title
feat: enable to use gcp secret manager
feat: support gcp secret manager for root user credentials
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
For better credential management
What
Errors
1. panic: interface conversion: ast.Expr is *ast.CompositeLit, not *ast.Ident
Solution: bump controller-gen to v0.9.0 that includes fix kubernetes-sigs/controller-tools#648
Updated Makefile following https://github.com/kubernetes-sigs/kubebuilder/blob/1f099eaf68d95df2edcb1d0f88a21af356bf279a/docs/book/src/migration/legacy/manually_migration_guide_v2_v3.md
Check list
MySQL
object