Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support gcp secret manager for root user credentials #190

Merged
merged 16 commits into from
Apr 5, 2023

Conversation

nakamasato
Copy link
Owner

@nakamasato nakamasato commented Apr 2, 2023

Why

For better credential management

What

  • Enable to read admin password from GCP SecretManager
  • Bump controller-gen to v0.9.0 to fix error & update Makefile

Errors

1. panic: interface conversion: ast.Expr is *ast.CompositeLit, not *ast.Ident

  1. https://github.com/nakamasato/mysql-operator/actions/runs/4601260750/jobs/8128914277
    /home/runner/work/mysql-operator/mysql-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
    panic: interface conversion: ast.Expr is *ast.CompositeLit, not *ast.Ident
    

Solution: bump controller-gen to v0.9.0 that includes fix kubernetes-sigs/controller-tools#648

Updated Makefile following https://github.com/kubernetes-sigs/kubebuilder/blob/1f099eaf68d95df2edcb1d0f88a21af356bf279a/docs/book/src/migration/legacy/manually_migration_guide_v2_v3.md

Check list

  • run in local
  • run with service account
  • test
    • update/delete MySQLClients when adding MySQL object
  • update diagram
  • add diagram to CONTRIBUTING.md

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #190 (678173c) into main (0d6bb49) will decrease coverage by 1.66%.
The diff coverage is 42.55%.

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
- Coverage   65.51%   63.86%   -1.66%     
==========================================
  Files           6        6              
  Lines         522      559      +37     
==========================================
+ Hits          342      357      +15     
- Misses        139      156      +17     
- Partials       41       46       +5     
Impacted Files Coverage Δ
controllers/mysql_controller.go 52.31% <42.55%> (-3.83%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nakamasato nakamasato added the enhancement New feature or request label Apr 5, 2023
@nakamasato nakamasato changed the title feat: enable to use gcp secret manager feat: support gcp secret manager for root user credentials Apr 5, 2023
@nakamasato nakamasato marked this pull request as ready for review April 5, 2023 22:08
@nakamasato nakamasato merged commit 8fe9cef into main Apr 5, 2023
@nakamasato nakamasato deleted the enable-to-use-gcp-secretmanager branch April 5, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant