Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reported test coverage with coveralls is wrong #1755

Closed
Raffo opened this issue Aug 26, 2020 · 0 comments · Fixed by #1762
Closed

Reported test coverage with coveralls is wrong #1755

Raffo opened this issue Aug 26, 2020 · 0 comments · Fixed by #1762
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@Raffo
Copy link
Contributor

Raffo commented Aug 26, 2020

We are reporting a badge with 12% test coverage:

image

This is clearly wrong, our test coverage is definitely higher. We should verify why this is happening and fixing the badge.
@Raffo Raffo added the kind/bug Categorizes issue or PR as related to a bug. label Aug 26, 2020
jgrumboe added a commit to porscheinformatik/external-dns that referenced this issue Aug 28, 2020
@jgrumboe
Fixes coverall coverage, kubernetes-sigs#1755
3d0b815
jgrumboe added a commit to porscheinformatik/external-dns that referenced this issue Aug 28, 2020
@jgrumboe
Fixes coverall coverage, kubernetes-sigs#1755
9da8234
jgrumboe added a commit to porscheinformatik/external-dns that referenced this issue Aug 28, 2020
@jgrumboe
Fixes coverall, kubernetes-sigs#1755
9114df9
jgrumboe added a commit to porscheinformatik/external-dns that referenced this issue Aug 28, 2020
@jgrumboe
Fixes coverall, kubernetes-sigs#1755
7bf381f
@jgrumboe jgrumboe mentioned this issue Aug 28, 2020
Merged
1 task
jgrumboe added a commit to porscheinformatik/external-dns that referenced this issue Sep 1, 2020
@jgrumboe
Fixes coverall, kubernetes-sigs#1755
541c22e
k8s-ci-robot added a commit that referenced this issue Sep 1, 2020
@k8s-ci-robot
Merge pull request #1762 from porscheinformatik/fix-coverall
cbde512 
Fixes coverall, #1755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes coverall, #1755 porscheinformatik/external-dns
1 participant
@Raffo