Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes coverall, #1755 #1762

Merged
merged 7 commits into from
Sep 1, 2020
Merged

Fixes coverall, #1755 #1762

merged 7 commits into from
Sep 1, 2020

Conversation

jgrumboe
Copy link
Contributor

@jgrumboe jgrumboe commented Aug 28, 2020 •
edited

**Fixes test coverage with coveralls **

This PR fixes the github CI action to generate a coverprofile.

Fixes #1755

Checklist

  • CHANGELOG.md updated, use section "Unreleased"

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 28, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 28, 2020
@seanmalloy
Copy link
Member

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 28, 2020
vinny-sabatini
vinny-sabatini suggested changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@vinny-sabatini vinny-sabatini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgrumboe it looks like this is working properly based on the status check result.

One small request, could you move the go test as a new Make target and call that in the ci?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2020
@Raffo
Copy link
Contributor

Raffo commented Aug 30, 2020

@jgrumboe please rebase. I promise that I will make the changelog experience better 😅

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 1, 2020
@jgrumboe
Copy link
Contributor Author

jgrumboe commented Sep 1, 2020

/hold
something broke 😢

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2020
@jgrumboe
Copy link
Contributor Author

jgrumboe commented Sep 1, 2020

/unhold
Everything allright .. coverall pages just needed some time for processing the results 😁

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2020
@jgrumboe
Copy link
Contributor Author

jgrumboe commented Sep 1, 2020

@vinny-sabatini I just moved the coverprofile argument to the test target of the Makefile. I didn't create a new target.

njuettner
njuettner approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgrumboe, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 1, 2020
@Raffo
Copy link
Contributor

Raffo commented Sep 1, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit cbde512 into kubernetes-sigs:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinny-sabatini vinny-sabatini vinny-sabatini requested changes

@njuettner njuettner njuettner approved these changes

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@Raffo Raffo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reported test coverage with coveralls is wrong
6 participants
@jgrumboe @seanmalloy @Raffo @k8s-ci-robot @njuettner @vinny-sabatini