-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DigitalOcean: Constant updates when TTL annotation is used on ingress #2754
Comments
Duplicate of #1421 If you try to set the TTL but the API does not support it, you will get constant drift and constant attempts to fix it. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What happened:
When
external-dns.alpha.kubernetes.io/ttl: "1m"
annotation is applied to the Ingress, external-dns tries to update the DNS records in DigitalOcean even if there were no changes to the IP of the node or DNS address.What you expected to happen:
No update.
How to reproduce it (as minimally and precisely as possible):
Set the aforementioned annotation.
Anything else we need to know?:
Looks like DO provider creates a record with TTL 0, disregarding the actual value:
https://github.com/kubernetes-sigs/external-dns/blob/master/provider/digitalocean/digital_ocean.go#L175
And this causes
shouldUpdateTTL
function to always returntrue
, resulting in an update.https://github.com/kubernetes-sigs/external-dns/blob/master/plan/plan.go#L197
Environment:
external-dns --version
): 0.11.1The text was updated successfully, but these errors were encountered: