-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: fix digital ocean provider not setting TTL #2857
Conversation
Welcome @Volatus! |
/kind bug |
/assign @Raffo |
@Volatus can you write a unit test to cover these code changes? |
@seanmalloy Isn't that already tested here essentially? external-dns/provider/digitalocean/digital_ocean_test.go Lines 304 to 311 in 579c8a8
Note: |
/close |
@Volatus: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@Volatus: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Ismayil Mirzali <ismayilmirzeli@gmail.com>
added unit test /cc @seanmalloy |
@Volatus: GitHub didn't allow me to request PR reviews from the following users: added, unit, test. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @seanmalloy any updates on this one? |
/ok-to-test |
/shrug |
/retest |
/test |
@Volatus: No presubmit jobs available for kubernetes-sigs/external-dns@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo, Volatus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR should fix the issue where the Digital Ocean provider unnecessarily tries to update records,
due to the TTL comparison that happens here.
The changes makes sure the TTL field is used when creating records.
Fixes #2754
Checklist
Signed-off-by: Ismayil Mirzali ismayilmirzeli@gmail.com