bug: fix digital ocean provider not setting TTL

[Volatus]

Description
This PR should fix the issue where the Digital Ocean provider unnecessarily tries to update records,
due to the TTL comparison that happens here.

func shouldUpdateTTL(desired, current *endpoint.Endpoint) bool {
	if !desired.RecordTTL.IsConfigured() {
		return false
	}
	return desired.RecordTTL != current.RecordTTL
}

The changes makes sure the TTL field is used when creating records.

Fixes #2754

Checklist

• Unit tests updated
• End user documentation updated

Signed-off-by: Ismayil Mirzali ismayilmirzeli@gmail.com

[k8s-ci-robot]

Welcome @Volatus!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[Volatus]

/kind bug

[Volatus]

/assign @Raffo

[seanmalloy]

@Volatus can you write a unit test to cover these code changes?

[Volatus]

@Volatus can you write a unit test to cover these code changes?

@seanmalloy Isn't that already tested here essentially?

external-dns/provider/digitalocean/digital_ocean_test.go

Lines 304 to 311 in 579c8a8

	r1 := makeDomainEditRequest("example.com", "example.com", endpoint.RecordTypeA,
	"1.2.3.4", digitalOceanRecordTTL)
	assert.Equal(t, &godo.DomainRecordEditRequest{
	Type: endpoint.RecordTypeA,
	Name: "@",
	Data: "1.2.3.4",
	TTL: digitalOceanRecordTTL,
	}, r1)

Note: digitalOceanRecordTTL is 300

[Volatus]

/close

[k8s-ci-robot]

@Volatus: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Volatus]

/reopen

[k8s-ci-robot]

@Volatus: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Volatus]

added unit test /cc @seanmalloy

[k8s-ci-robot]

@Volatus: GitHub didn't allow me to request PR reviews from the following users: added, unit, test.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @seanmalloy added unit test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Volatus]

/cc @seanmalloy any updates on this one?

[szuecs]

/ok-to-test

[Volatus]

/shrug

[Volatus]

/retest

[Volatus]

/test

[k8s-ci-robot]

@Volatus: No presubmit jobs available for kubernetes-sigs/external-dns@master

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[Volatus]

/remove-lifecycle stale

[Raffo]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, Volatus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Raffo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment