-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provider structure refactor #1565
Conversation
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
Thanks Raffo, ok for me 👍. I just merged one PR for dnsimple, would you mind fixing it? |
Sure, will fix the dnsimple stuff. EDIT: done. |
/lgtm |
@njuettner I'll wait a couple of days max for @linki in case he wants to further review this, then proceed with merging this as I'd rather have this branch be short lived, given the impact it has on the code structure. |
oh well, the bot was faster 😅 |
This PR refactors the provider structure by separating them in different folders. I've touched only the providers and none of the logic of the providers themselves. I'm fairly convinced that this is the right structure to allow us to move forward and scale the maintainers as discussed in #1558 .
I will not:
I am aware that this will put a bit of additional effort on the existing PRs as they'll likely need to rebase those changes, this is why I don't want to touch too much the code.
/cc @linki @njuettner