Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider structure refactor #1565

Merged
merged 7 commits into from
May 11, 2020
Merged

Conversation

Raffo
Copy link
Contributor

@Raffo Raffo commented May 8, 2020

This PR refactors the provider structure by separating them in different folders. I've touched only the providers and none of the logic of the providers themselves. I'm fairly convinced that this is the right structure to allow us to move forward and scale the maintainers as discussed in #1558 .
I will not:

  • touch the sources (that will be done in a later PR)
  • touch other parts of the code / do further restructuring unless mentioned in the code review.

I am aware that this will put a bit of additional effort on the existing PRs as they'll likely need to rebase those changes, this is why I don't want to touch too much the code.

/cc @linki @njuettner

Raffo added 2 commits May 8, 2020 13:05
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 8, 2020
@Raffo Raffo marked this pull request as ready for review May 8, 2020 11:59
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2020
Raffo added 3 commits May 8, 2020 19:08
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo Raffo changed the title WIP provider structure refactor Provider structure refactor May 8, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2020
@njuettner
Copy link
Member

Thanks Raffo, ok for me 👍. I just merged one PR for dnsimple, would you mind fixing it?
@linki you wanna have a look as well 🤗 ?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2020
@Raffo
Copy link
Contributor Author

Raffo commented May 11, 2020

Sure, will fix the dnsimple stuff.

EDIT: done.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2020
@njuettner
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2020
@Raffo
Copy link
Contributor Author

Raffo commented May 11, 2020

@njuettner I'll wait a couple of days max for @linki in case he wants to further review this, then proceed with merging this as I'd rather have this branch be short lived, given the impact it has on the code structure.

@k8s-ci-robot k8s-ci-robot merged commit 2ef1503 into master May 11, 2020
@Raffo
Copy link
Contributor Author

Raffo commented May 11, 2020

oh well, the bot was faster 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants