Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale and improve ExternalDNS contributions #1558

Closed
2 of 5 tasks
Raffo opened this issue May 6, 2020 · 19 comments
Closed
2 of 5 tasks

Scale and improve ExternalDNS contributions #1558

Raffo opened this issue May 6, 2020 · 19 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@Raffo
Copy link
Contributor

Raffo commented May 6, 2020

I had a chat with @mrbobbytables today on Slack around improving the contributor experience of ExternalDNS.
We (read: the maintainers of the project) have been struggling with maintaining providers and sources, mostly due to bandwidth issues. Different approaches have been discussed over time, without reaching a decent compromise between what we have in terms of bandwidth and what makes sense for the project. For example, in #1447 we discussed having different ways to plug sources and providers, all with possible shortcomings (that's life, I guess).
There's an interesting consideration that is always valid: lots of these problems are not only a maintainers' problem, rather mostly an ownership problem. In that context, it could be interesting to try the following:

  • Split sources and providers in dedicated folders
  • Add to the kubernetes-sigs orgs anyone that writes/maintains a new provider
  • Add maintainers of specific providers/sources to the provider as reviewers first, approvers later

This should allow the "core" maintainers to focus on core and not on other parts and reduce the signal to noise ration in terms of issues as well.

Definition of done

This issue is done if those are done 👇 :

  • Split sources and providers in dedicated folders
  • Add to the kubernetes-sigs orgs anyone that writes/maintains a new provider
  • Add maintainers of specific providers/sources to the provider as reviewers first, approvers later
  • We have a better contribution guide that specifies what will be done in terms of membership

Bonus items

Those are nice to have but not required right now:

  • Label issues for new contributions / help wanted

Slightly related: #408

/cc @njuettner @linki

@Raffo Raffo self-assigned this May 6, 2020
@szuecs
Copy link
Contributor

szuecs commented May 6, 2020

Thanks @Raffo !
I am happy to help and split RouteGroup to its own directory.

@mazzy89
Copy link

mazzy89 commented May 22, 2020

Hey @Raffo not a Traefik maintainer here speaking however to make progress in the Traefik v2 support, can I be anyhow helpful?

@Raffo
Copy link
Contributor Author

Raffo commented May 23, 2020

@mazzy89 if you mean to support another source, I'll have a PR ready to split the sources next week.

@mazzy89
Copy link

mazzy89 commented May 23, 2020

Yes. I would need external DNS to deal with Traefik v2 CRDs

@ddymko
Copy link
Contributor

ddymko commented May 28, 2020

Hey @Raffo I would be glad to help maintain the Vultr provider

@vinny-sabatini
Copy link
Contributor

@Raffo and @njuettner I have worked with @seanmalloy on triaging the issues and will try to help chip away at some of them.

@seanmalloy
Copy link
Member

seanmalloy commented Aug 19, 2020

I completed adding the "kind" label to all open pull requests. My next step is to start working with @vinny-sabatini to review size/XS and size/S pull requests.

  • We have a better contribution guide that specifies what will be done in terms of membership

@Raffo and @njuettner do you just want the contributing docs cleaned up and updated? Or is there something very specific you want done? I think this might be something myself and @vinny-sabatini could complete.

@Raffo and @njuettner would you have any concerns if I was added to this repo with GitHub Triage permissions? I'm a kubernetes-sigs org member and a reviewer for the k8s descheduler. This would allow me to add some additional labels to open issues and pull requests in an effort to help keep things organized. For example I want to add the provider/aws, provider/google, provider/azure, etc labels. I'd take care of submitting the PR here to add myself with Triage permissions. Let me know what you think. Thanks!

@seanmalloy
Copy link
Member

PR to start improving contributor experience #1760. After this one is merged I believe I'll be submitting one more PR to get the last bits of contributor docs updated.

@Raffo
Copy link
Contributor Author

Raffo commented Aug 29, 2020

would you have any concerns if I was added to this repo with GitHub Triage permissions? I'm a kubernetes-sigs org member and a reviewer for the k8s descheduler.

I have no concerns, feel free to create a PR for that. Depending on the amount of time and interest that you have, we can go as far as adding you to the approvers list, given that after #1761 we have only two approvers and that is not something good for the project.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 27, 2020
@Raffo
Copy link
Contributor Author

Raffo commented Nov 27, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 27, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 25, 2021
@seanmalloy
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 25, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 26, 2021
@timbunce
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 25, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 24, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

10 participants