Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Inactive Maintainers To Emeritus Approvers #1761

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

seanmalloy
Copy link
Member

Description
The goal of this pull requests it to make it easier for contributors to identify the active project maintainers, so that there is not confusion around pull requests reviews.

Is related to #1558.

Checklist

  • Unit tests updated
  • End user documentation updated
  • CHANGELOG.md updated, use section "Unreleased"

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 28, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 28, 2020
@tariq1890
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2020
@seanmalloy
Copy link
Member Author

@Raffo and @njuettner it is my understanding that @linki and @hjacobs are no longer active maintainers of this project. Therefore I'm proposing moving them to the emeritus_approvers section of the OWNERS file. Let me know if my understanding is correct or not. Thanks!

/kind cleanup
/assign @Raffo @njuettner
/cc @linki @hjacobs

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 28, 2020
@hjacobs
Copy link
Contributor

hjacobs commented Aug 28, 2020

I'm not sure what the implications are, but I'm obviously inactive and don't even have the expertise to do proper code reviews for External DNS.

@tariq1890
Copy link
Contributor

@hjacobs You'll need to comment with /approve :)

Copy link
Contributor

@Raffo Raffo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense.

@Raffo
Copy link
Contributor

Raffo commented Aug 29, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 30a5083 into kubernetes-sigs:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants