Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Contributing Documentation #1760

Merged
merged 3 commits into from
Sep 2, 2020
Merged

Update Contributing Documentation #1760

merged 3 commits into from
Sep 2, 2020

Conversation

seanmalloy
Copy link
Member

@seanmalloy seanmalloy commented Aug 28, 2020 •
edited
Loading

Description
The goal of this change is to improve the external-dns contributor experience and encourage more community members to participate. This is the first of two pull requests to improve the contributor experience. The next pull request will update the files under docs/contributing.

Is related to #1558.

Checklist

  • Unit tests updated
  • End user documentation updated
  • CHANGELOG.md updated, use section "Unreleased"

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2020
@seanmalloy
Copy link
Member Author

I don't think this change is worthy of a CHANGELOG entry. Therefore I did not update the CHANGELOG.md file.

@vinny-sabatini and @tariq1890 please take a look when you have some time. Thanks!

/cc @tariq1890

@seanmalloy seanmalloy mentioned this pull request Aug 28, 2020
Closed
5 tasks
@seanmalloy
Copy link
Member Author

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 28, 2020
vinny-sabatini
vinny-sabatini approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@vinny-sabatini vinny-sabatini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seanmalloy seanmalloy force-pushed the docs-round-3 branch 2 times, most recently from 5ef3fb2 to aa7fed6 Compare September 1, 2020 13:59
Raffo
Raffo approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@Raffo Raffo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment only.

README.md Outdated
Comment on lines 321 to 322
The external-dns project is also in need of automated end-to-end tests for different DNS providers. Any help from the
Kubernetes community and ideas on how this can be accomplished would be valuable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanmalloy can we drop this entirely and use issues to signal what we need instead of the readme?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Raffo fixed in 4ffb615

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1770

@seanmalloy
Copy link
Member Author

The coveralls CI test is showing that test coverage is decreasing by 0.008%. I believe this might block this PR from being merged. This PR only changes *.md files. No *.go files are being changed. Looks like this might be a problem.

@seanmalloy
Copy link
Member Author

@Raffo all requested changes have been made. Please let me know if any other changes are needed.

@Raffo
Copy link
Contributor

Raffo commented Sep 2, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0ef226f into kubernetes-sigs:master Sep 2, 2020
@seanmalloy seanmalloy deleted the docs-round-3 branch September 2, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinny-sabatini vinny-sabatini vinny-sabatini approved these changes

@linki linki Awaiting requested review from linki

@tariq1890 tariq1890 Awaiting requested review from tariq1890

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@Raffo Raffo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanmalloy @Raffo @k8s-ci-robot @vinny-sabatini