-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quick start section to contributor docs #1766
Add quick start section to contributor docs #1766
Conversation
e232653
to
e893e98
Compare
/cc @tariq1890 @tariq1890 and @vinny-sabatini please review when you get a chance. Thanks! |
/kind documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor tweak here, the rest looks good to me
f86ca3b
to
f52c47a
Compare
@vinny-sabatini fixed. Good catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @Raffo @njuettner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo, seanmalloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Added a quick start section to the contributing documentation. The purpose of this documentation is to help new contributors get started working with the external-dns project.
Updated
docs/contributing/getting-started.md
with recommend local development workflow. Removed documentation fromREADME.md
for compiling from source.Is related to #1558
Checklist