-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pod source [kops compatibility] #2032
Conversation
Welcome @olemarkus! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one 👍🏻 , I would suggest adding in the readme some documentation around kops compatibility (what are we covering with this PR). Do you mind adding something there?
I'm happy to merge your PR 🥳 and thanks again.
Great. Thanks. As mentioned, I was thinking of adding to the docs as part of the followup. There is a checklist in the README right now that mention kOps as a drop-in replacement and it would make sense to tick that one off at least partially. If you can point me to where in the readme I should drop a mention, I would be happy to add one as part of this PR as well. |
So what we could do is adding additional checkmarks in the readme for https://github.com/kubernetes-sigs/external-dns#v10 under "Ability to replace Kops' DNS Controller") |
Pod source is a key feature of kOps' DNS Controller. Among other things, i is used for etcd and API discovery.
Sounds good. Have a look now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
The pod source will implement the logic described for pods here: https://github.com/kubernetes-sigs/external-dns/blob/master/docs/legacy/kops-dns-controller.md
This PR just reuses the usual external-dns annotations. A follow-up will add support for the dns-controller annotations, possibly using the
--compatibility
flag as suggested on the page linked above.The pod source is a key feature of kOps' DNS Controller. Among other things, i is used for etcd and API discovery.
Relates to #221 and #1997
Checklist
With this PR and the follow-up on the dns-controller annotation compat support, I am hoping it can be used as a drop-in replacement for 70% of kOps users (gossip provider being another major feature needed for 100%). The end-user documentation should be around using external-dns as a drop-in for dns-controller, I think, so would be nice if we could wait a little bit with that one.