Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod source [kops compatibility] #2032

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

olemarkus
Copy link
Contributor

Description

The pod source will implement the logic described for pods here: https://github.com/kubernetes-sigs/external-dns/blob/master/docs/legacy/kops-dns-controller.md

This PR just reuses the usual external-dns annotations. A follow-up will add support for the dns-controller annotations, possibly using the --compatibility flag as suggested on the page linked above.

The pod source is a key feature of kOps' DNS Controller. Among other things, i is used for etcd and API discovery.

Relates to #221 and #1997

Checklist

  • Unit tests updated
  • End user documentation updated

With this PR and the follow-up on the dns-controller annotation compat support, I am hoping it can be used as a drop-in replacement for 70% of kOps users (gossip provider being another major feature needed for 100%). The end-user documentation should be around using external-dns as a drop-in for dns-controller, I think, so would be nice if we could wait a little bit with that one.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 30, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @olemarkus!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 30, 2021
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍🏻 , I would suggest adding in the readme some documentation around kops compatibility (what are we covering with this PR). Do you mind adding something there?

I'm happy to merge your PR 🥳 and thanks again.

@olemarkus
Copy link
Contributor Author

Great. Thanks. As mentioned, I was thinking of adding to the docs as part of the followup. There is a checklist in the README right now that mention kOps as a drop-in replacement and it would make sense to tick that one off at least partially. If you can point me to where in the readme I should drop a mention, I would be happy to add one as part of this PR as well.

@njuettner
Copy link
Member

So what we could do is adding additional checkmarks in the readme for https://github.com/kubernetes-sigs/external-dns#v10 under "Ability to replace Kops' DNS Controller")

Pod source is a key feature of kOps' DNS Controller.
Among other things, i is used for etcd and API discovery.
@olemarkus
Copy link
Contributor Author

Sounds good. Have a look now.

@olemarkus olemarkus requested a review from njuettner April 7, 2021 06:17
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9b1183f into kubernetes-sigs:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants