Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluecat: allow setting tls verify and TTL #2052

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

vinny-sabatini
Copy link
Contributor

@vinny-sabatini vinny-sabatini commented Apr 16, 2021

Description

Allow users of the Bluecat provider to enable and disable TLS Verify

Fixes #2023

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 16, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 16, 2021
@vinny-sabatini vinny-sabatini force-pushed the bluecat-tls branch 2 times, most recently from cd2ac72 to 458c2a4 Compare April 16, 2021 20:39
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 16, 2021
@vinny-sabatini
Copy link
Contributor Author

/assign @seanmalloy

@vinny-sabatini vinny-sabatini marked this pull request as ready for review April 16, 2021 20:54
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2021
Within the Bluecat config file, you can now set the `InsecureSkipVerify`
for all API calls made to the Bluecat Gateway. This is controlled with
by the boolean value of `skipTLSVerify`. If this is unset, TLS
verification is enforced.
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2021
@vinny-sabatini vinny-sabatini mentioned this pull request Apr 16, 2021
2 tasks
@seanmalloy
Copy link
Member

/kind feature
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seanmalloy, vinny-sabatini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 46a88b1 into kubernetes-sigs:master Apr 16, 2021
@vinny-sabatini vinny-sabatini deleted the bluecat-tls branch April 16, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provider/bluecat: allow toggling TLS verification
3 participants