Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluecat documentation #2053

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Bluecat documentation #2053

merged 2 commits into from
Apr 22, 2021

Conversation

vinny-sabatini
Copy link
Contributor

@vinny-sabatini vinny-sabatini commented Apr 16, 2021 •
edited

Description

Add documentation for TLS Verification, and setup GitHub labeling for Bluecat provider

Relates to #2023 and #2052

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 16, 2021
@vinny-sabatini
Copy link
Contributor Author

I am not sure what the process is to create a new label in this repository, but we would like a new label with the name provider/bluecat to better organize work being done on that provider. @Raffo / @njuettner is this something that is done in a different repo?

CC: @seanmalloy

@seanmalloy
Copy link
Member

@Raffo and @njuettner I'm assuming one of you would just go into the repo settings and add the new label. I'm not aware of a way to programmatically create repo labels for the k8s project, but please correct me if I'm wrong. Thanks!

/kind documentation
/lgtm
/assign @Raffo @njuettner

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 16, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2021
@njuettner
Copy link
Member

Added bluecat as label ❤️

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, vinny-sabatini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5806e34 into kubernetes-sigs:master Apr 22, 2021
@seanmalloy seanmalloy deleted the bluecat-docs branch April 22, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner njuettner approved these changes

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@Raffo Raffo

@seanmalloy seanmalloy

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. provider/bluecat size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vinny-sabatini @seanmalloy @njuettner @k8s-ci-robot @Raffo