-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubernetes v1.22: Update controller to use networking.k8s.io/v1 Ingress. #2281
kubernetes v1.22: Update controller to use networking.k8s.io/v1 Ingress. #2281
Conversation
Welcome @andrewstuart! |
exciting, i'm waiting on this to use it in my setup 🎉 |
@andrewstuart I think this is a fair change and as breaking as it could be, it's has been plenty of kubernetes releases already that those APIVersions are available. |
/lgmt |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewstuart, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Could anyone give me some help about when this issue is expected to be released? Currently I could see that it's in master branch, but I don't know if this issue will be include in next release (I suppose yes) and when next release will be ready to be used. Thank you so much! |
Hello Adrian, See this for more info: #1861 (comment) |
Don't forget to update the Helm chart! |
hello folks, just build the image from this merge on master : docker.io/smartdeploy/external-dns:latest . Thanks to all by the way i just upgrade my helm install. |
@Raffo Any word on that new release? |
Description
This PR should fix the problem of external-dns not running in v1.22. It does not provide backwards compatibility for extensions/v1beta1 ingresses as this should still be backwards compatible going back to v1.19 without any other code; I don't know the typical policy for this SIG, but given that v1beta1 Ingress has been removed, this seems safe enough (and much simpler).
Fixes #2168
Checklist