-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correcting README #2535
Correcting README #2535
Conversation
Updating the kubernetes version compatibility section in README
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Welcome @milindchawre! |
/check-cla |
/retest |
@milindchawre: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
Thank you @milindchawre |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: milindchawre, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updating the kubernetes version compatibility section in README
It's true that the breaking change that was added in externaldns v0.10.0 should not impact k8s version >= 1.19. But it's also true that externaldns version <=0.9.x which uses
extensions/v1beta1
should work on k8s version <= 1.21 since it was removed in k8s v1.22 and was just deprecated since k8s v1.19.