[Rfc2136] Add message compression

[kumy]

Description

When facing large messages, one can have its dns refusing the update due to "too large message" error. The DNS library used has an option to compress the message that is sent.

This commit exposes this feature. It adds a new command line option called --rfc2136-enable-compression and adds a new field to the configuration. The default value of the field is set to false to not change the current behavior.

We had this change pending locally on our side since a long time. As of today, an alternative would be to use the recent batchChangeSize option from #2127 to overcome the same issue.

Relates to #1322 #1164

Checklist

• Unit tests updated (current tests should pass, we'll add dedicated tests soon)
• End user documentation updated (also added some words for rfc2136: add batch size support #2127)

[k8s-ci-robot]

Welcome @kumy!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kumy
To complete the pull request process, please assign njuettner after the PR has been reviewed.
You can assign the PR to them by writing /assign @njuettner in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[kumy]

Hi, anyone to review this please?

[Raffo]

/remove-lifecycle stale

[Raffo]

Trying to figure out why CI didn’t run on this one and then I’ll work on a review.

[linux-foundation-easycla]

• ❌ - kumy The commit (c54b7b4) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[Raffo]

@kumy please check the CLA. I think you might have to squash the commits and force push to make sure that no commits are breaking the CLA.

[kumy]

@boris-lenzinger As I leaved, I find it better if you could please do it under your name? Thanks 🙏