Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reintroduce klog replace #2361

Merged
merged 3 commits into from
Oct 11, 2021
Merged

reintroduce klog replace #2361

merged 3 commits into from
Oct 11, 2021

Conversation

Raffo
Copy link
Contributor

@Raffo Raffo commented Oct 9, 2021 •
edited
Loading

Fixes #2348

@Raffo
reintroduce klog replace
b74de32 
Signed-off-by: GitHub <noreply@github.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2021
@Raffo
go.sum
abc5d81 
Signed-off-by: GitHub <noreply@github.com>
@Raffo
fix go.sum
16286c1 
Signed-off-by: GitHub <noreply@github.com>
@Raffo Raffo mentioned this pull request Oct 9, 2021
Closed
@Raffo
Copy link
Contributor Author

Raffo commented Oct 9, 2021

/cc @njuettner fo stamps

@k8s-ci-robot
Copy link
Contributor

@Raffo: GitHub didn't allow me to request PR reviews from the following users: stamps, fo.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @njuettner fo stamps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

njuettner
njuettner approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3676ea0 into master Oct 11, 2021
@mloiseleur mloiseleur mentioned this pull request Aug 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner njuettner approved these changes

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tons of useless warning log messages for instrumented_http.Transport
3 participants
@Raffo @k8s-ci-robot @njuettner