Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove useless warning log messages for instrumented_http.Transport #3870

Merged
merged 3 commits into from
Aug 31, 2023
Merged

fix: remove useless warning log messages for instrumented_http.Transport #3870

merged 3 commits into from
Aug 31, 2023

Conversation

mloiseleur
Copy link
Contributor

@mloiseleur mloiseleur commented Aug 14, 2023 •
edited

Description

It was removed in #3697 by last update on go modules.

It fixes #2348.
See PR #2361.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 14, 2023
@mloiseleur
Copy link
Contributor Author

cc @szuecs @johngmyers

@johngmyers
Copy link
Contributor

Is it possible to create a test, if not address with some way other than replace? It seems this would be likely to regress on a future dependency update.

@mloiseleur
Copy link
Contributor Author

That's a good question. I'll see what I can do about it.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 25, 2023
@mloiseleur
Copy link
Contributor Author

@johngmyers @Raffo Maybe I've seen found a better way to fix it, see 30c8a0f

I've tested it manually by calling klog.Info before and after, like apimachinery does, and it seems to work.

@mloiseleur
Copy link
Contributor Author

/test pull-external-dns-lint

@Raffo
Copy link
Contributor

Raffo commented Aug 25, 2023

Ah nice that seems like a good way. I'd love to see how logs look like with those changes.

johngmyers
johngmyers reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@johngmyers johngmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

main.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2023
@johngmyers
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2023
@Raffo
Copy link
Contributor

Raffo commented Aug 31, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit f17e24f into kubernetes-sigs:master Aug 31, 2023
14 checks passed
@mloiseleur mloiseleur deleted the fix/log branch September 1, 2023 06:57
@mloiseleur mloiseleur mentioned this pull request Nov 8, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers left review comments

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

@szuecs szuecs Awaiting requested review from szuecs

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tons of useless warning log messages for instrumented_http.Transport
4 participants
@mloiseleur @johngmyers @Raffo @k8s-ci-robot