-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cluster role permissions for other sources #2468
Conversation
@stevehipwell it does look like that issue is related. I didn't notice that PR since it wasn't attached to issue #2324. I made the change to add the kong-tcpingress and just figured I would try to add others while I was in here. I am fine with adding a generic value to add user-defined API permissions to the cluster role. I will try to get to that soonish. |
@krmichel does your PR replace the other one or are they complimentary? I can see that yours is pretty comprehensive. |
@stevehipwell mine has the same changes for crd that the other one has so it could replace it. |
@krmichel are you ready for a review or still making changes? |
@stevehipwell I think waiting would be good until I get the generic permissions change in place so end users can add what they want. |
@stevehipwell I think this is ready for review now |
/lgtm |
@Raffo is |
Not sure, tagging @njuettner here. |
@Raffo sorry I added |
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krmichel, Raffo, stevehipwell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This adds additional cluster role permissions based on the selected sources.
I believe that this fixes these issues
Fixes #2464
Fixes #2315
Fixes #2324