-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore cluster role permissions to read services when Istio sources are enabled #2415
Restore cluster role permissions to read services when Istio sources are enabled #2415
Conversation
@haines I think |
3a6d2a5
to
381f4b5
Compare
Fine by me @stevehipwell - updated 🙂 |
/approve |
381f4b5
to
4b4f11a
Compare
@Raffo do you want to take a look and add the LGTM? |
@Raffo could you please take a look? |
/approve |
4b4f11a
to
53ab904
Compare
@stevehipwell rebase done - I'm happy to create a follow-up PR with a version bump and changelog in the chart once this is merged, unless you'd rather do it. Should that PR also include an application version bump to 0.10.2? The thing that makes me hesitate is that the release is marked as a pre-release in GitHub. |
@haines I'm waiting to hear back about the |
/approve |
@Raffo could you take a look and add a LGTM if you're happy? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haines, Raffo, stevehipwell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I totally forgot to check whether the Istio sources relied on any of the core APIs in #2413 😳
Turns out that they need to have read permissions on services as well as the Istio custom resources.