-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[chart]: Update to ExternalDNS v0.12.0 #2777
Conversation
|
Welcome @vojtechmares! |
@vojtechmares I've got #2776 to release v0.12.0 assigned to myself as there are a couple of lifecycle changes I was planning on making as part of the release. I'll make my changes and if you can rebase on top of them, once merged, your PR can do the release. |
@stevehipwell ok. Sorry I did not check the issue, I am working and I just checked if there is a release and since there wasn't one, I've created a PR. Can I help with the lifecycle changes? EDIT: Sorry for not checking the issues beforehand. Yet I guess in this case it is not a big deal. |
@stevehipwell rebased onto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vojtechmares, could you look at the changes I've suggested?
@stevehipwell I've force-pushed again with suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vojtechmares.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevehipwell, vojtechmares The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
@vojtechmares could you add a closes statement to the PR description for #2776? |
@seanmalloy could you enable the tests to run? For the record I was expecting adding |
@stevehipwell done. Added to PR desc. |
@stevehipwell I've approved the test run. For reference this repo uses GitHub Actions, so adding the ok-to-test label doesn't work in this repo. |
@seanmalloy I'd have thought the k8s-ci-robot could automate it? AFAIK this approval was a recent GitHub actions change introduced to stop the malicious use of compute. Any suggestions for where to ask about this? |
@stevehipwell as far as I know the CI robot doesn't do this. Seems like a good feature to add to the robot. |
Hello @seanmalloy, can you review this PR please? |
/lgtm |
@vojtechmares |
Updating Helm chart to ExternalDNS v0.12.0
I've inspired myself with last commit updating the helm chart from v0.10.2 to v0.11.0 (a26ac53)
Closes #2776