Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Helm chart CHANGELOG for v1.10.0 #2856

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Fix Helm chart CHANGELOG for v1.10.0 #2856

merged 1 commit into from
Jul 8, 2022

Conversation

stevehipwell
Copy link
Contributor

@stevehipwell stevehipwell commented Jul 4, 2022 •
edited

Description

This PR fixes the broken chart release for v1.10.0 caused by a missing CHANGELOG entry in #2777.

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 4, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2022
@stevehipwell
Copy link
Contributor Author

/assign @seanmalloy

@stevehipwell
chore[chart]: Fix CHANGELOG for v1.10.0
d978e25 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@stevehipwell stevehipwell mentioned this pull request Jul 4, 2022
Merged
@stevehipwell
Copy link
Contributor Author

/assign @Raffo

@seanmalloy
Copy link
Member

/kind bug
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seanmalloy, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 579c8a8 into kubernetes-sigs:master Jul 8, 2022
@stevehipwell stevehipwell deleted the fix-helm-release-v1-10-0 branch July 9, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmalloy seanmalloy seanmalloy approved these changes

@njuettner njuettner Awaiting requested review from njuettner

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@Raffo Raffo

@seanmalloy seanmalloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stevehipwell @seanmalloy @k8s-ci-robot @Raffo