Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): Added ability to customise the service account labels. #3145

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Nov 9, 2022

Signed-off-by: Jan-Otto Kröpke mail@jkroepke.de

Description

Added ability to customise the service account labels.

AKS Workload Identity requires labels on service accounts.

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2022
@stevehipwell
Copy link
Contributor

@Raffo @njuettner @seanmalloy could someone enable the GH workflow to run?

@stevehipwell
Copy link
Contributor

@Raffo could you approve the GH workflows?

@stevehipwell
Copy link
Contributor

@jkroepke could you rebase this PR, it should automatically run the GH workflows as your other PR was merged.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@stevehipwell
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2022
@stevehipwell
Copy link
Contributor

@njuettner could you approve this?

@stevehipwell
Copy link
Contributor

@Raffo could you review and approve this?

@Raffo
Copy link
Contributor

Raffo commented Dec 2, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkroepke, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit bbd007e into kubernetes-sigs:master Dec 2, 2022
@jkroepke jkroepke deleted the sa-labels branch December 9, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants