Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[chart]: Updated chart to v0.13.1 #3197

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

stevehipwell
Copy link
Contributor

Description

This PR updates the version of ExternalDNS in the Helm chart to v0.13.1 and releases the chart.

Fixes #3101

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 28, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2022
@stevehipwell
Copy link
Contributor Author

@Raffo the failing check isn't relevant to the chart and seems to be failing across the board?

@stevehipwell
Copy link
Contributor Author

@Raffo can you merge this change with the failing test? The Helm chart uses a previously published binary. Longer term I think it might be worth removing the Helm path from some of the test triggers?

@stevehipwell stevehipwell force-pushed the chart-v0-13-1 branch 2 times, most recently from d61a830 to 9ffdcbc Compare November 29, 2022 17:05
@stevehipwell stevehipwell marked this pull request as draft November 29, 2022 17:11
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2022
@stevehipwell
Copy link
Contributor Author

@Raffo if we can get #3144 & #3145 merged before the release let's try for that. I've set this to draft so I can rebase and update the CHANGELOG after the merges go through.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2022
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2022
@stevehipwell stevehipwell marked this pull request as ready for review December 5, 2022 07:53
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2022
@stevehipwell
Copy link
Contributor Author

@seanmalloy @szuecs @njuettner could you review this as it's now ready?

CC @Raffo

@Raffo
Copy link
Contributor

Raffo commented Dec 6, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5920619 into kubernetes-sigs:master Dec 6, 2022
@stevehipwell stevehipwell deleted the chart-v0-13-1 branch December 7, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release chart for v0.13.1
3 participants