Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the right query params on infoblox #3301

Merged

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Jan 9, 2023

Description

Infoblox provider is not doing the proper query/search params. It ends up doing a huge query on infoblox, trying to fetch all registries from all zones and views for every zone external-dns manages, when it should get only the registries that belongs to that zone.

This PR adds the search parameter correctly, using zone and view to find just the managed entries.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2023
@rikatz
Copy link
Contributor Author

rikatz commented Jan 9, 2023

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 9, 2023
@rikatz
Copy link
Contributor Author

rikatz commented Jan 9, 2023

uh buh! this error is not from my change :D

I can, tho, fix using this PR or a different one if required!

@carpenterm
Copy link

@njuettner @seanmalloy Please could we retest this? It's a small change but fixes a significant performance issue in the Infoblox provider. We are running this internally in production.

@seanmalloy
Copy link
Member

I'll try to review it today.

@craicoverflow
Copy link

Hey @rikatz this is failing on a small lint error

@nxf5025
Copy link

nxf5025 commented May 2, 2023

@rikatz - Any idea when you can address the lint error? Would love to see this merged out.

@rikatz
Copy link
Contributor Author

rikatz commented May 2, 2023

yes, right now. Let me take a look

@rikatz rikatz force-pushed the fix-externaldns-infoblox-queries branch from 043458d to 2484da5 Compare May 2, 2023 15:11
@rikatz
Copy link
Contributor Author

rikatz commented May 2, 2023

ok folks, this is passing now.

@szuecs @seanmalloy just so this doesn't fall off of your plate :D

Thanks!!

@szuecs
Copy link
Contributor

szuecs commented May 3, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 510eb95 into kubernetes-sigs:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants