fix(infoblox): set view and zone query parameters

[cronik]

Description

The zone and view search query parameters are not included in record search requests. This can result in more records returned in the query than necessary.

For example if more than one zone is returned, rather than issuing a query on each respective zone it is searching all zones on each iteration.

In our environment we noticed a reduction in response body size from around 14MB down to 1MB.

Checklist

• Unit tests updated
• End user documentation updated

[k8s-ci-robot]

Welcome @cronik!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[cronik]

I believe this PR partially or completely fixes #3207

[cronik]

The recently merged #3301 introduced a regression by defaulting the view query parameter to "default". I tested a query in my environment which does not have a "default" view and it fails with

{
	"Error": "AdmConDataNotFoundError: View default not found",
	"code": "Client.Ibap.Data.NotFound",
	"text": "View default not found"
}

#3301 also added searchParameters to the PTR record query. But according to the comment in that block the arpa zone must be used for that query, not fqdn.

This PR includes the view parameter to the zones query if present.

/kind bug

[szuecs]

/ok-to-test
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cronik, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [szuecs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[johngmyers]

/lgtm

[johngmyers]

/test pull-external-dns-lint
/test pull-external-dns-unit-test